On 06/20/2017 12:08 AM, Bart Van Assche wrote:
> From: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
>
> The variable 'disk_type' is never modified so constify it.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Cc: Hannes Reinecke <hare@xxxxxxxx>
> Cc: Omar Sandoval <osandov@xxxxxx>
> Cc: Ming Lei <ming.lei@xxxxxxxxxx>
> ---
> block/genhd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/genhd.c b/block/genhd.c
> index d252d29fe837..7f520fa25d16 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -36,7 +36,7 @@ struct kobject *block_depr;
> static DEFINE_SPINLOCK(ext_devt_lock);
> static DEFINE_IDR(ext_devt_idr);
>
> -static struct device_type disk_type;
> +static const struct device_type disk_type;
>
> static void disk_check_events(struct disk_events *ev,
> unsigned int *clearing_ptr);
> @@ -1183,7 +1183,7 @@ static char *block_devnode(struct device *dev, umode_t *mode,
> return NULL;
> }
>
> -static struct device_type disk_type = {
> +static const struct device_type disk_type = {
> .name = "disk",
> .groups = disk_attr_groups,
> .release = disk_release,
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
