On 06/16/2017 01:30 AM, Christoph Hellwig wrote: > On Thu, Jun 15, 2017 at 09:23:02AM -0600, Jens Axboe wrote: >> And then I remembered why fadvise _sucks_. It returns the error value >> directly. So 0 is success > 0 is some error. That does not work well >> for adding a set/get interface. Additionally, with fadvise, we have >> to overload either 'offset' or 'length' for the write hint for the >> set operation. Not super pretty. >> >> Any objections to making the auxiliary interface fcntl(2) based? >> That would be a cleaner fit, imho. > > fcntl sounds fine to me. v5 implemented that, much better fit than fadvise. -- Jens Axboe
