Ooh, one more thing. On Mon, Jun 12, 2017 at 02:20:28PM -0400, Tejun Heo wrote: > > +struct kernfs_node *kernfs_get_node_by_ino(struct kernfs_root *root, > > + unsigned int ino) Can we name this kernfs_find_and_get_by_ino() for consistency? And the RCU optimization does seem prominent compared to other find/get functions which all just use kernfs_mutex (still not objecting). Thanks. -- tejun