On Wed, May 31, 2017 at 03:52:37PM -0700, Bart Van Assche wrote: > Instead of explicitly calling scsi_req_init() after blk_get_request(), > call that function from inside blk_get_request(). Add an > .initialize_rq_fn() callback function to the block drivers that need > it. Merge the IDE .init_rq_fn() function into .initialize_rq_fn() > because it is too small to keep it as a separate function. Keep the > scsi_req_init() call in ide_prep_sense() because it follows a > blk_rq_init() call. Looks fine except for the method placement in the mq case mentioned in the previous patch: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
