Re: [PATCH] blk-mq: Take tagset lock when updaing hw queues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Keith Busch <keith.busch@xxxxxxxxx> writes:

> The tagset lock needs to be held when iterating the tag_list, so a
> lockdep assert was added when updating number of hardware queues. The
> drivers calling this API, however, were unaware of the new requirement,
> so are failing the assertion.
>
> This patch takes the lock within the blk-mq function so the drivers do
> not have to be modified in order to be safe.
>
> Fixes: 705cda97e ("blk-mq: Make it safe to use RCU to iterate over blk_mq_tag_set.tag_list")
>
> Reported-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxxxx>
> Reviewed-by: Bart Van Assche <Bart.VanAssche@xxxxxxxxxxx>
> Signed-off-by: Keith Busch <keith.busch@xxxxxxxxx>

I know it is already applied but, FWIW, I can confirm it fixed the issue
in our CI.  Feel free to add:

Tested-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxxxx>

Thanks again, Keith.

-- 
Gabriel Krisman Bertazi



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux