Re: [PATCH v2 5/8] blk-mq: update comments on blk_mq_quiesce_queue()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2017-05-27 at 22:21 +0800, Ming Lei wrote:
>  /**
> - * blk_mq_quiesce_queue() - wait until all ongoing queue_rq calls have finished
> + * blk_mq_quiesce_queue() - wait until all ongoing dispatching have finished
>   * @q: request queue.
>   *

Hello Ming,

The concept of dispatching does not have a meaning to block driver authors who are
not familiar with the block layer internals. However, every author of a blk-mq driver
knows what the .queue_rq() function is. Additionally, the new comment is grammatically
incorrect. So the above change looks like a step in the wrong direction to me.

Bart.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux