On Wed, May 24, 2017 at 04:04:40PM +0000, Bart Van Assche wrote:
> Are you sure that that code is not necessary? From osd_initiator.c:
>
> static void _put_request(struct request *rq)
> {
> /*
> * If osd_finalize_request() was called but the request was not
> * executed through the block layer, then we must release BIOs.
> * TODO: Keep error code in or->async_error. Need to audit all
> * code paths.
> */
> if (unlikely(rq->bio))
> blk_end_request(rq, -ENOMEM, blk_rq_bytes(rq));
> else
> blk_put_request(rq);
> }
Which isn't using it at all. It has a ten year old comment to pass
on some error, but even then ORing two different error types together
would no be very helpful.
>
> Bart.---end quoted text---
