On Fri, May 12, 2017 at 11:09 PM, Avri Altman <Avri.Altman@xxxxxxxxxxx> wrote: >> + req = blk_get_request(mq->queue, >> + idata[0]->ic.write_flag ? REQ_OP_DRV_OUT : REQ_OP_DRV_IN, >> + __GFP_RECLAIM); > > It is possible, e.g. as in RPMB access, that some commands are read and some are write. > Not sure that it makes any difference, because once it get back to mmc_blk_ioctl_cmd_issue(), > The correct mmc requests will be issued anyway? The OP type (REQ_OP_DRV_OUT or REQ_OP_DRV_IN) has no semantic effect in the MMC/SD stack, I just need to set it to something reasonable. They will all be handled the same when issueing the request later. The only semantic effect would be if the block layer prioritize these types of requests differently compared to each other or to other requests, in which case I think this rough guess is not a big issue. Yours, Linus Walleij
