On 3/20/25 9:27 AM, Matthew Wilcox wrote:
On Thu, Mar 20, 2025 at 09:15:23AM -0700, Bart Van Assche wrote:
The patch description mentions what has been changed but does not
mention why. Shouldn't the description of this patch explain why this
change has been made? Shouldn't the description of this patch explain
for which applications this change is useful?
The manufacturer chooses the block size. If they've made a bad decision,
their device will presumably not sell well. We don't need to justify
their decision in the commit message.
The fact that this change is proposed because there are device
manufacturers that want to produce devices with block sizes larger than
64 KiB would be useful information for the commit message.
Thanks,
Bart.
