Re: [PATC] block: update queue limits atomically

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 18, 2025 at 03:26:10PM +0100, Mikulas Patocka wrote:
> The block limits may be read while they are being modified. The statement
> "q->limits = *lim" is not really atomic. The compiler may turn it into
> memcpy (clang does).

And that is intentional.

> This commit changes it to use WRITE_ONCE, so that individual words are
> updated atomically.

You fail to explain why the intentended non-atomic semantics are a
problem.

Note: it usually helps to Cc the other of the commit you suspect is
broken if you want a quick resolution.





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux