On Mar 11, 2025 / 22:59, Christoph Hellwig wrote: > On Tue, Mar 11, 2025 at 07:43:59PM +0900, Shin'ichiro Kawasaki wrote: > > /* > > * Batched completions only work when there is no I/O error and no special > > * ->end_io handler. > > + * > > + * @req: The request to add to batch > > + * @iob: The batch to add the request > > + * @is_error: Specify true if the request failed with an error > > + * @io_comp_batch: The completaion handler for the request > > */ > > This needs more work to be a proper kerneldoc comment, i.e. start with > "/*8", mention the function name, etc. Ah, thanks. I should have checked the kerneldoc format. Jens already queued up this patch (thanks!), so I will send out a separate, follow-up patch to fix the kerneldoc comment. The follow-up patch will be posted to linux-block list, with reduced To/Cc members.