On Tue, Mar 11, 2025 at 09:21:14AM +0800, Ming Lei wrote: > On Mon, Mar 10, 2025 at 12:11:20PM +0100, Christoph Hellwig wrote: > > On Sun, Mar 09, 2025 at 12:23:07AM +0800, Ming Lei wrote: > > > Add helper loop_queue_work_prep() for making loop_queue_rq() more > > > readable. > > > > Looking at this and the finaly result I don't really see any advantage > > over just moving the code into loop_queue_work. > > loop_queue_work() is required for handling -EAGAIN, that is why I move > loop_queue_work_prep() into loop_queue_work(). Yes, but please just add the code directly to loop_queue_work instead of adding a not very clearly defined helper.
