On Sun, 09 Mar 2025 12:05:56 -0400, colyli@xxxxxxxxxx wrote: > In _badblocks_check(), there are lines of code like this, > 1246 sectors -= len; > [snipped] > 1251 WARN_ON(sectors < 0); > > The WARN_ON() at line 1257 doesn't make sense because sectors is > unsigned long long type and never to be <0. > > [...] Applied, thanks! [1/1] badblocks: Fix a nonsense WARN_ON() which checks whether a u64 variable < 0 commit: 7e76336e14de9a2b67af96012ddd46c5676cf340 Best regards, -- Jens Axboe