On Mar 05, 2025 / 10:51, Yu Kuai wrote:
> Hi,
>
> 在 2025/03/04 23:18, Ming Lei 写道:
> > Add test for covering prioritized meta IO when throttling, regression
> > test for commit 29390bb5661d ("blk-throttle: support prioritized processing
> > of metadata").
Thank you Ming for this v2 patch. I reverted the commit 29390bb5661d from the
kernel v6.14-rc5, and confirmed the test case fails.
> >
> > Cc: Yu Kuai <yukuai1@xxxxxxxxxxxxxxx>
> > Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>
> > ---
> > V2:
> > - add ext4 jbd2 task into the cgroup(Kuai)
> > - use 4M size IO(Kuai)
> >
> > tests/throtl/006 | 62 ++++++++++++++++++++++++++++++++++++++++++++
> > tests/throtl/006.out | 4 +++
> > tests/throtl/rc | 19 ++++++++++++++
> > 3 files changed, 85 insertions(+)
> > create mode 100755 tests/throtl/006
> > create mode 100644 tests/throtl/006.out
> >
>
> LGTM, just one nit below:
>
> > diff --git a/tests/throtl/006 b/tests/throtl/006
> > new file mode 100755
> > index 0000000..23b30dc
> > --- /dev/null
> > +++ b/tests/throtl/006
> > @@ -0,0 +1,62 @@
> > +#!/bin/bash
> > +# SPDX-License-Identifier: GPL-3.0+
> > +# Copyright (C) 2025 Ming Lei
> > +#
> > +# Test prioritized meta IO when IO throttling, regression test for
> > +# commit 29390bb5661d ("blk-throttle: support prioritized processing of metadata")
> > +
> > +. tests/throtl/rc
> > +
> > +DESCRIPTION="test if meta IO has higher priority than data IO"
> > +QUICK=1
> > +
> > +requires() {
> > + _have_program mkfs.ext4
>
> Perhaps also add
> _have_kernel_option EXT4_FS
That's a good improvement. "_have_driver ext4" does the same check and is a bit
shorter. So I folded it in.
>
> feel free to add:
> Reviewed-by: Yu Kuai <yukuai3@xxxxxxxxxx>
FYI, I applied the patch, folding in my nit comments for the v1 patch also.
Thanks!
