On 05/04/2017 09:31 AM, Omar Sandoval wrote: > From: Omar Sandoval <osandov@xxxxxx> > > Originally, I tied debugfs registration/unregistration together with > sysfs. There's no reason to do this, and it's getting in the way of > letting schedulers define their own debugfs attributes. Instead, tie the > debugfs registration to the lifetime of the structures themselves. > > The saner lifetimes mean we can also get rid of the extra mq directory > and move everything one level up. I.e., nvme0n1/mq/hctx0/tags is now > just nvme0n1/hctx0/tags. > > Signed-off-by: Omar Sandoval <osandov@xxxxxx> > --- > block/blk-core.c | 9 +--- > block/blk-mq-debugfs.c | 110 ++++++++++++++++++++++++++++--------------------- > block/blk-mq-debugfs.h | 21 ++++++++-- > block/blk-mq-sysfs.c | 11 ----- > block/blk-mq.c | 7 ++++ > block/blk-sysfs.c | 2 + > include/linux/blk-mq.h | 4 ++ > include/linux/blkdev.h | 1 - > 8 files changed, 94 insertions(+), 71 deletions(-) > Again, I really liked the symmetry between sysfs and debugfs mq entries. This will definitely break it. Not sure if that's a real issue, but personally I liked the mapping. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
