On 05/04/2017 09:31 AM, Omar Sandoval wrote: > From: Omar Sandoval <osandov@xxxxxx> > > It's not clear what these numbered directories represent unless you > consult the code. We're about to get rid of the intermediate "mq" > directory, so these would be even more confusing without that context. > > Signed-off-by: Omar Sandoval <osandov@xxxxxx> > --- > block/blk-mq-debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c > index 109ae9f3d400..2eae3238fb35 100644 > --- a/block/blk-mq-debugfs.c > +++ b/block/blk-mq-debugfs.c > @@ -936,7 +936,7 @@ static int blk_mq_debugfs_register_hctx(struct request_queue *q, > char name[20]; > int i; > > - snprintf(name, sizeof(name), "%u", hctx->queue_num); > + snprintf(name, sizeof(name), "hctx%u", hctx->queue_num); > hctx_dir = debugfs_create_dir(name, q->mq_debugfs_dir); > if (!hctx_dir) > return -ENOMEM; > Hmm. The number actually corresponds to /sys/block/XX/mq/<num> With this patch we would break this mapping, no? I'd rather keep it in sync with /sys/block ... Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
