On 2/25/25 8:43 PM, Christoph Hellwig wrote: > On Tue, Feb 25, 2025 at 07:00:41PM +0530, Nilay Shroff wrote: >> The wbt latency and state could be updated while initializing the >> elevator or exiting the elevator. It could be also updates while >> configuring IO latency QoS parameters using cgroup. The elevator >> code path is now protected with q->elevator_lock. So we should >> protect the access to sysfs attribute wbt_lat_usec using q->elevator >> _lock instead of q->sysfs_lock. White we're at it, also protect >> ioc_qos_write(), which configures wbt parameters via cgroup, using >> q->elevator_lock. > > Please expand the comment near the elevator_lock field to mention > that it protects wbt_lat_usec. > Ok, will be addressed in the next patchset. Thanks, --Nilay
