Re: [PATCH 05/12] badblocks: return error if any badblock set fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





在 2025/2/22 14:16, Coly Li 写道:
On Sat, Feb 22, 2025 at 09:12:53AM +0800, Yu Kuai wrote:
Hi,

在 2025/02/21 18:12, Coly Li 写道:
So we don’t need to add a negative return value for partial success/failure?

Coly Li.

Yes, I think so. No one really use this value, and patch 10 clean this
up by changing return type to bool.

OK, then it is fine to me.

It will be good to add a code comment that parital setting will be treated as failure.

Thanks.



Thank you for your review. I will add comment in the next version.

--
Thanks,
Nan





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux