> + /* > + * We don't use atomic update helper queue_limits_start_update() and > + * queue_limits_commit_update() here for updaing ra_pages bacause > + * blk_apply_bdi_limits() which is invoked from queue_limits_commit_ > + * update() can overwrite the ra_pages value which user actaully wants > + * to store here. The blk_apply_bdi_limits() sets value of ra_pages > + * based on the optimal I/O size(io_opt). > + */ Maybe replace this with: /* * ra_pages is protected by limit_lock because it is usually * calculated from the queue limits by queue_limits_commit_update. */