Re: [PATCHv2 6/6] blk-sysfs: protect read_ahead_kb using q->limits_lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +	/*
> +	 * We don't use atomic update helper queue_limits_start_update() and
> +	 * queue_limits_commit_update() here for updaing ra_pages bacause
> +	 * blk_apply_bdi_limits() which is invoked from  queue_limits_commit_
> +	 * update() can overwrite the ra_pages value which user actaully wants
> +	 * to store here. The blk_apply_bdi_limits() sets value of ra_pages
> +	 * based on the optimal I/O size(io_opt).
> +	 */

Maybe replace this with:

	/*
	 * ra_pages is protected by limit_lock because it is usually
	 * calculated from the queue limits by queue_limits_commit_update.
	 */





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux