On Fri, Feb 14, 2025 at 11:34:07AM +0000, Shinichiro Kawasaki wrote: > On Feb 12, 2025 / 12:54, Luis Chamberlain wrote: > > This v3 series addresses the feedback from the v2 series [0] and > > makes some minor new changes, the change are: > > > > - Fixes all shellcheck complaints > > - Addresses spacing / tabs fixes > > - Adds _test_dev_suits_xfs() as suggested by Shinichiro and makes > > tests which require this depend on it > > - Clamps _min_io() to 4k as well for backward compatibility > > - Few minor enhancements to help capture up error messages from > > mkfs from block/032 > > > > This goes tested against a 64k sector size NVMe drive, and also > > using ./check so regular loopback devices are used. This helps > > test 64k sector devices, patches for which have been posted [1]. > > > > [0] https://lkml.kernel.org/r/20250204225729.422949-1-mcgrof@xxxxxxxxxx > > [1] https://lkml.kernel.org/r/20250204231209.429356-1-mcgrof@xxxxxxxxxx > > Luis, thank you very much for the improvements. I made comments on some of > the patches. FYI, I reflected my comments on your patches, and pushed them to a > github repo branch [2]. Please take a look in them and see if my comments make > sense or not. > > [2] https://github.com/kawasaki/blktests/commits/bs_ps/ Looks good, thanks for doing this, passes all my tests too, please feel free to merge :) Luis
