On Wed Feb 12, 2025 at 12:14 PM CET, Maurizio Lombardi wrote: > On Wed Feb 12, 2025 at 11:28 AM CET, Maurizio Lombardi wrote: >> On Wed Feb 12, 2025 at 10:47 AM CET, zhang.guanghui@xxxxxxxx wrote: >>> Hi, Thanks. >>> I will test this patch, but I am worried whether it will affect the performance. >>> Should we also consider null pointer protection? >> >> Yes, it will likely affect the performance, just check if it works. >> >> Probably it could be optimized by just protecting >> nvme_tcp_fail_request(), which AFAICT is the only function in the >> nvme_tcp_try_send() code that calls nvme_complete_rq(). > > Something like that, maybe, not tested: Ah wait, this won't fix anything because it will end up with a double completion. Ok I am not sure how to fix this, someone else maybe has better ideas. Maurizio
