On 1/31/25 21:00, Christoph Hellwig wrote: > The loop driver currently uses the logical block size of the underlying > bdev as the lower bound of the loop device block size. While this works > for many cases, it fails for file systems made up of multiple devices > with different logic block size (e.g. XFS with a RT device that has a Nit: s/logic block size/logical block sizes > larger logical block size), or when the file systems doesn't support > direct I/O writes at the sector size granularity (e.g. because it does > out of place writes with a file system block size larger than the sector > size). > > Fix this by querying the minimum direct I/O alignment from statx when > available. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Other than that, looks OK to me. Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx> -- Damien Le Moal Western Digital Research
