On Wed, Jan 29, 2025 at 07:05:34AM +0100, Christoph Hellwig wrote: > On Tue, Jan 28, 2025 at 05:34:46PM +0100, Daniel Wagner wrote: > > If a lot of request are in the queue, this message is spamming the logs, > > thus rate limit it. > > Are in the queue when what happens? Not that I'm against this, > but if we have a known condition where this error is printed a lot > we should probably skip it entirely for that? The condition is that all the elements in the queue->send_list could fail as a batch. I had a bug in my patches which re-queued all the failed command immediately and semd them out again, thus spamming the log. This behavior doesn't exist in upstream. I just thought it might make sense to rate limit as precaution. I don't know if it is worth the code churn.
