On 05/02/2017 08:45 AM, Christoph Hellwig wrote: > On Tue, May 02, 2017 at 12:21:23PM +0200, Jan Kara wrote: >> it makes sense to treat REQ_FUA and REQ_PREFLUSH ops as synchronous in >> op_is_sync() since callers cannot rely on this anyway... Thoughts? > > I'm fine with treating them as sync. Yes me too. It makes sense to do so implicitly, and it avoids having to go and add REQ_SYNC in a bunch of places. That will also be more error proof in the future. Jan, will you send a patch for that? -- Jens Axboe