On Tue, Jan 28, 2025 at 10:47:12AM +0100, David Hildenbrand wrote: > Yes, I did that renaming as part of that series after the name was suggested > during review. I got confused myself reading this report. > > internal_get_user_pages_fast() -> gup_fast_fallback() > > Was certainly an improvement. Naming is hard, we want to express "try fast, > but fallback to slow if it fails". > > Maybe "gup_fast_with_fallback" might be clearer, not sure. gup_common?