On Fri, Jan 10, 2025 at 09:15:09AM +0000, John Garry wrote: >> + int (*store_limit)(struct gendisk *disk, const char *page, > > I don't really see why this returns an int, while the queue features > callback methods return a ssize_t. I know that the res variable in > queue_attr_store() gets mixed with an int for updating the queue limits, > but I don't see that as a reason to use int here. The normal store methods have the annoying calling convention where they return the parsed string length on success. ->store_limits uses the simpler and harder to get wrong convention of returning 0 on success.
