On Tue, Jan 07, 2025 at 12:28:29PM +0530, Nilay Shroff wrote: > > - blk_mq_freeze_queue(ns->disk->queue); > > lim = queue_limits_start_update(ns->disk->queue); > > nvme_set_ctrl_limits(ns->ctrl, &lim); > > + > > + blk_mq_freeze_queue(ns->disk->queue); > > ret = queue_limits_commit_update(ns->disk->queue, &lim); > > set_disk_ro(ns->disk, nvme_ns_is_readonly(ns, info)); > > blk_mq_unfreeze_queue(ns->disk->queue); > > I think we should freeze queue before nvme_set_ctrl_limits(). Why?