On 1/6/25 19:59, Christoph Hellwig wrote: > On Mon, Jan 06, 2025 at 07:56:19PM +0900, Damien Le Moal wrote: >> On 1/6/25 7:06 PM, Christoph Hellwig wrote: >>> So far cache_type_store didn't freeze the queue, fix that by using the >>> queue_limits_commit_update_frozen helper. >>> >>> Signed-off-by: Christoph Hellwig <hch@xxxxxx> >> >> This should be squashed in patch 2, no ? > > patch 2 is supposed to just be a mechanical conversion, and each > behavior change should be in it's own patch. Sounds good to me, but let's be consistent then: do not remove the freeze/unfreeze from virtio_blk in patch 2 and do it here in this patch. Otherwise, patch 2 *does* change the behavior of virtio_blk, introducing a bug (missing freeze around commit update). -- Damien Le Moal Western Digital Research
