On Mon, 2017-05-01 at 17:49 +0200, markus@xxxxxxxxxxxxxxx wrote: > On 2017.05.01 at 15:18 +0000, Bart Van Assche wrote: > > Your patch duplicates the code to remove trailing whitespace which is not > > very elegant. Please move the code that removes trailing whitespace from > > __elevator_change() into elv_iosched_store() instead of duplicating it. > > Yes, I thought about it, but the problem is that elevator_change() calls > __elevator_change(), too. Hello Markus, In kernel v4.11 elevator_change() only has a single caller and that caller passes an elevator name with no trailing whitespace. I am aware that the elevator_change() function is exported and hence could be used by out-of-tree kernel drivers. However, we do not care about potential behavior changes for out-of-tree drivers. Bart.
