On Mon, Jan 06, 2025 at 07:55:30PM +0900, Damien Le Moal wrote: > > + lim->features |= BLK_FEAT_IO_STAT | BLK_FEAT_NOWAIT | BLK_FEAT_POLL; > > Why set BLK_FEAT_POLL unconditionally ? This is changing the current default > for many devices, no ? Due to the runtime check it doesn't actually change behavior. But it does change the value read from sysfs, which also need extra check for poll queues. But the entire point is that we don't have to update this field when updating the queues, so yes it should be set unconditonally.