On 1/6/25 7:06 PM, Christoph Hellwig wrote: > Add a helper that freezes the queue, updates the queue limits and > unfreezes the queue and convert all open coded versions of that to the > new helper. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> [...] > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > index 71a7ffeafb32..0a987f195630 100644 > --- a/drivers/block/virtio_blk.c > +++ b/drivers/block/virtio_blk.c > @@ -1105,9 +1105,7 @@ cache_type_store(struct device *dev, struct device_attribute *attr, > lim.features |= BLK_FEAT_WRITE_CACHE; > else > lim.features &= ~BLK_FEAT_WRITE_CACHE; > - blk_mq_freeze_queue(disk->queue); > i = queue_limits_commit_update(disk->queue, &lim); You need to change this line to use queue_limits_commit_update_frozen(). Other than that, looks good ! -- Damien Le Moal Western Digital Research
