On Dec 18, 2024 / 18:38, Ming Lei wrote: > On Wed, Dec 18, 2024 at 6:17 PM Shinichiro Kawasaki > <shinichiro.kawasaki@xxxxxxx> wrote: > > > > On Dec 13, 2024 / 15:36, Ming Lei wrote: > > > When io_uring is disabled, ublk_ctrl_init() will return NULL, so we > > > have to check the result. > > > > > > Fixes segment fault reported from Yi. > > > > Ming, let me confirm, the segmentation fault was reported in the blktests GitHub > > PR 153 [1]. AFAIU, the segmentation fault cause is in liburing, not in blktests > > src/miniublk.c. So I guess that this patch is not needed. Do you have same view? > > Hi Shinichiro, > > This patch fixes another segment fault which is miniublk specific. Got it, I have applied this patch. Thanks!