On Tue, 10 Dec 2024 20:11:43 +0530, Nilay Shroff wrote: > For storing a value to a queue attribute, the queue_attr_store function > first freezes the queue (->q_usage_counter(io)) and then acquire > ->sysfs_lock. This seems not correct as the usual ordering should be to > acquire ->sysfs_lock before freezing the queue. This incorrect ordering > causes the following lockdep splat which we are able to reproduce always > simply by accessing /sys/kernel/debug file using ls command: > > [...] Applied, thanks! [1/1] block: Fix potential deadlock while freezing queue and acquiring sysfs_lock commit: be26ba96421ab0a8fa2055ccf7db7832a13c44d2 Best regards, -- Jens Axboe