On Thu, 2017-04-27 at 16:51 -0600, Jens Axboe wrote:
> This is a prep patch for backoff in ->queue_rq() for non-ncq commands.
>
> Signed-off-by: Jens Axboe <axboe@xxxxxx>
> ---
> drivers/block/mtip32xx/mtip32xx.c | 28 ++++++++++++++++++----------
> 1 file changed, 18 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
> index 36f3d34f2156..f0732cc92864 100644
> --- a/drivers/block/mtip32xx/mtip32xx.c
> +++ b/drivers/block/mtip32xx/mtip32xx.c
> @@ -1030,6 +1030,22 @@ static bool mtip_pause_ncq(struct mtip_port *port,
> return false;
> }
>
> +static bool mtip_commands_active(struct mtip_port *port)
> +{
> + unsigned int n;
> + unsigned int active = 1;
Hello Jens,
Initializing 'active' doesn't harm but I don't think that is needed in this
function. Anyway:
Reviewed-by: Bart Van Assche <Bart.VanAssche@xxxxxxxxxxx>
