On 11/28/24 14:21, Christoph Hellwig wrote: > On Thu, Nov 28, 2024 at 02:19:23PM +0900, Damien Le Moal wrote: >> Sounds good. What do you think of adding the opportunistic "update zone wp" >> whenever we execute a user report zones ? It is very easy to do and should not >> slow down significantly report zones itself because we usually have very zone >> write plugs and the hash search is fast. > > Just user or any report zones? But I think updating it is probably a > good thing. When the zone state is requested there is no excuse to > not have the write plug information in sync All report zones. That would cover things like an FS mkfs report zones putting everything in sync and an FS or dm-zoned doing a report zones after a write error syncing single zones. To do that, all that is needed is a default report zones callback that syncs write plugs that have the "need update" flag and then call the user specified report zones callback. -- Damien Le Moal Western Digital Research