On Tue, Nov 26, 2024 at 09:09:56AM +0900, Damien Le Moal wrote: > To facilitate testing of kernel functions related to the rotational > feature (BLK_FEAT_ROTATIONAL) of a block device (e.g. NVMe rotational > bit support), add the rotational boolean configfs attribute and module > parameter to the null_blk driver. If set, a null block device will > report being a rotational device through it queue limits features with > the BLK_FEAT_ROTATIONAL flag. Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>