On Tue, 19 Nov 2024 17:11:49 +0100, Christoph Hellwig wrote: > Dan's smatch run pointed out that there is no need to check for a NULL > req->bio in the merge bio into request and request merge helpers > because they can't ever be reached by flush or passthrough requests. > > While validing that I also found a few other odd bits directly next > to it, so this two-patch series fixes all of that. > > [...] Applied, thanks! [1/2] block: don't bother checking the data direction for merges commit: 9f8d68283342a48f692f2c02231318bb4a7b207f [2/2] block: req->bio is always set in the merge code commit: 81314bfbde9d089fa2318adba54891dfaadb1c05 Best regards, -- Jens Axboe