On 18/11/24 11:58, Christoph Hellwig wrote:
On Sat, Nov 16, 2024 at 05:02:57PM +0530, Suraj Sonawane wrote:
Apologies for any confusion earlier, and thank you for your attention to
this. After further analysis, I realize that this change isn't necessary, as
bio is already set to NULL by bio_alloc_clone on failure, preventing any
real case of uninitialized use. My initial patch aimed to clean up the code
and satisfy smatch, ensuring better readability and error handling.
I appreciate your feedback and the opportunity to learn from this. I now
understand that no change is needed here. Thank you for your guidance and
understanding.
FYI, I still think the change is useful. It makes the code a lot
better to read for humans and machines, and fixes a static checker
false positive. So I'd still love to see it, it just needs a better
commit log. Feel free to contact me off list if you need help with
that.
Thank you for your valuable input and for encouraging me to improve the
patch. I have sent a V5 version of the patch with an updated and
detailed commit log, including a thorough explanation of the changes and
a summary of the discussion so far.
You can find the patch here:
https://lore.kernel.org/lkml/20241119164412.37609-1-surajsonawane0215@xxxxxxxxx/
I appreciate your willingness to review it and provide feedback.
Best regards,
Suraj Sonawane
