Re: [PATCH] block: return unsigned int from bdev_io_min

[John Garry <john.g.garry@xxxxxxxxxx>]

On 19/11/2024 07:26, Christoph Hellwig wrote:
> The underlying limit is defined as an unsigned int, so return that from
> bdev_io_min as well.

There seem to be other helpers with the same condition.

Even bdev_io_opt() is defined as returning an int, but actually returns 
an unsigned int. And even though not a bdev helper, 
queue_dma_alignment() is similar.

> Fixes: ac481c20ef8f ("block: Topology ioctls")
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>

> ---
>   include/linux/blkdev.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 00212e96261a..4825469c2fa1 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1261,7 +1261,7 @@ static inline unsigned int queue_io_min(const struct request_queue *q)
>   	return q->limits.io_min;
>   }
>   
> -static inline int bdev_io_min(struct block_device *bdev)
> +static inline unsigned int bdev_io_min(struct block_device *bdev)
>   {
>   	return queue_io_min(bdev_get_queue(bdev));
>   }