Hi Christoph, On Tue, Nov 19, 2024 at 04:34:52AM -0800, Christoph Hellwig wrote: > On Tue, Nov 19, 2024 at 03:27:13PM +0300, Alexey Romanov wrote: > > Since we use custom backend implementation, we remove the ability > > for users to use algorithms from crypto backend. This breaks > > backward compatibility, user doesn't necessarily use one of the > > algorithms from "custom" backends defined in zram folder. > > For example, he can use some driver with hardware compression support. > > > > This patch adds opinion to enable Crypto API: add ZRAM_BACKEND_CRYPTO_API. > > Option is enabled by default, because in previously version of ZRAM > > it was possible to choose any alogirthm using Crypto API. This is > > also done for backward compatibility purposes. > > Which crypto API algorithm do you care about? You should probably > just add a backend for that instead of a double indirection. > Should I create backend_*.c file for every compression algo driver? Okay, there aren't many of them now. But what will do, for example, when there will be 250 such compression drivers? And also your approach doesn't allow working with loadable modules. For example, we may have only binary module (without sources) from vendor SDK that provieds a driver for data compression. This is an even bigger problem. -- Thank you, Alexey
