On 18.11.2024 15:08, Miguel Ojeda wrote:
On Mon, Nov 18, 2024 at 2:12 PM Manas via B4 Relay
<devnull+manas18244.iiitd.ac.in@xxxxxxxxxx> wrote:
`Result` is used in place of `Result<()>` because the default type
parameters are unit `()` and `Error` types, which are automatically
inferred. This patch keeps the usage consistent throughout codebase.
The tags you had in v1 (Link, Suggested-by) seem to have been removed.
Nit: the usual style is to use the imperative tense when describing
the change that the patch performs, although that is not a hard rule,
e.g. you could say "Thus keep the usage consistent throughout the
codebase." in the last sentence.
Will do.
Signed-off-by: Manas <manas18244@xxxxxxxxxxx>
Same comment as in v1 about the "known identity".
Actually, "Manas" is my __official__ name.
(The notes above apply to the other patches too).
The change itself looks fine to me of course, so with those fixed,
please feel free to add in your next version:
Reviewed-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
Adding tags in v3.
--
Manas
