On 04/26/2017 03:48 AM, Ming Lei wrote: > Hi Christoph, > > On Thu, Apr 20, 2017 at 04:30:42PM +0800, Ming Lei wrote: >> Hi Christoph, >> >> On Wed, Apr 19, 2017 at 09:54:08PM -0700, Christoph Hellwig wrote: >>> On Thu, Apr 20, 2017 at 09:03:47AM +0800, Ming Lei wrote: >>>> If we don't need to reserve tag for internal command, I am happy >>>> to fix it in the interim. However, the mtip32xx driver has to >>>> ask blk-mq to reserve the tag zero for internal command. Then >>>> if we can't allow the driver to use that reserved tag, it looks >>>> quite awkward, doesn't it? >>> >>> It doesn't. Just offset the hardware tags by 1 from the blk-mq tags. >>> >>> But I'm pretty sure the hardware wouldn't require a specific tag >>> for the internal ops. >> >> From mtip32xx code, the tag 0 is used to send internal command only, and >> not used for submitting normal request. >> >> From code of mtip_issue_non_ncq_command() and mtip_issue_ncq_command(), >> even same hardware address is writen to when issuing non-ncq and ncq >> commands. So I think the internal ops and normal requests share one same >> tag space on mtip32xx. >> >> Could you explain it a bit why you think the hw doesn't need the tag >> for internal ops in this case? > > Gentle ping... > > Looks there are some choices for this issue: > > 1) if internal ops uses independent tag space > - we need to clean up the mtip32xx driver > > 2) if internal ops shares tag space with normal request > - export blk_mq_get_driver_tag() for mtip32xx > > or > > - use private way to send internal ops, and the drawback > is that we still need to reserve tag and the reserved tag > can't be used at all. > > From mtip32xx source code, I can see both share same tag space. > When I try to search hw manual via google, not succeed yet. > > Christoph, could you share us your findings about if internal ops > uses independent tag space or not? Why aren't we just bypassing for RESERVED? If someone is asking for an reserved tag, ensure that we use the right tag pool (sched vs normal) and sub pool (reserved vs normal). Then insert just bypasses the scheduler, like it already does if we have a driver tag assigned already. I've got a few of these cards, but traveling. I'll wire up something and test it end this week. -- Jens Axboe
