Re: [PATCH] rust: simplify Result<()> uses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 17, 2024 at 07:25:48PM +0100, Andrew Lunn wrote:
> On Sun, Nov 17, 2024 at 08:41:47PM +0530, Manas via B4 Relay wrote:
> > From: Manas <manas18244@xxxxxxxxxxx>
> > 
> > This patch replaces `Result<()>` with `Result`.
> > 
> > Suggested-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> > Link: https://github.com/Rust-for-Linux/linux/issues/1128
> > Signed-off-by: Manas <manas18244@xxxxxxxxxxx>
> > ---
> >  drivers/net/phy/qt2025.rs        | 2 +-
> >  rust/kernel/block/mq/gen_disk.rs | 2 +-
> >  rust/kernel/uaccess.rs           | 2 +-
> >  rust/macros/lib.rs               | 6 +++---
> 
> Please split these patches up per subsystem, and submit them
> individually to the appropriate subsystems.

In addition, it would be good if the commit stated the rationale for
the change, rather than what the change is (which we can see from the
patch itself.)

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux