Re: [PATCH 1/2] block: pre-calculate max_zone_append_sectors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/9/24 00:46, Christoph Hellwig wrote:
> max_zone_append_sectors differs from all other queue limits in that the
> final value used is not stored in the queue_limits but needs to be
> obtained using queue_limits_max_zone_append_sectors helper.  This not
> only adds (tiny) extra overhead to the I/O path, but also can be easily
> forgotten in file system code.
> 
> Add a new max_hw_zone_append_sectors value to queue_limits which is
> set by the driver, and calculate max_zone_append_sectors from that and
> the other inputs in blk_validate_zoned_limits, similar to how
> max_sectors is calculated to fix this.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Link: https://lore.kernel.org/r/20241104073955.112324-3-hch@xxxxxx
> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>

Looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>

-- 
Damien Le Moal
Western Digital Research




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux