Re: [PATCH] block: Switch to using refcount_t for zone write plugs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/7/24 4:07 AM, Damien Le Moal wrote:
On 11/7/24 16:27, Christoph Hellwig wrote:
On Thu, Nov 07, 2024 at 03:54:38PM +0900, Damien Le Moal wrote:
Replace the raw atomic_t reference counting of zone write plugs with a
refcount_t.  No functional changes.

I don't quite see the point, but if Jens wants to take it the code
changes look correct to me:

The point is only to avoid kernel bots screaming about the use of atomic for
refcounting. Nothing more than that.

There may be better approaches to achieve this goal, e.g. introducing an
annotation scheme that makes these bots ignore zwplug->ref. I prefer the
annotation approach because I'm concerned that this patch will have a
negative performance for ZNS and ZUFS devices.

Thanks,

Bart.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux