On 11/7/24 09:23, LongPing Wei wrote:
> It should be better to call bdev_offset_from_zone_start()
> instead of open-coding it.
Make this simply:
Call bdev_offset_from_zone_start() instead of open-coding it.
With that, looks good to me, so feel free to add:
Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
>
> Fixes: dd291d77cc90 ("block: Introduce zone write plugging")
> Signed-off-by: LongPing Wei <weilongping@xxxxxxxx>
> ---
> v3: update commit message
> ---
> block/blk-zoned.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
> index af19296fa50d..77a448952bbd 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -537,7 +537,7 @@ static struct blk_zone_wplug *disk_get_and_lock_zone_wplug(struct gendisk *disk,
> spin_lock_init(&zwplug->lock);
> zwplug->flags = 0;
> zwplug->zone_no = zno;
> - zwplug->wp_offset = sector & (disk->queue->limits.chunk_sectors - 1);
> + zwplug->wp_offset = bdev_offset_from_zone_start(disk->part0, sector);
> bio_list_init(&zwplug->bio_list);
> INIT_WORK(&zwplug->bio_work, blk_zone_wplug_bio_work);
> zwplug->disk = disk;
--
Damien Le Moal
Western Digital Research
