Re: [PATCH 1/2] block: RCU protect disk->conv_zones_bitmap

[Bart Van Assche <bvanassche@xxxxxxx>]

On 11/6/24 3:13 PM, Damien Le Moal wrote:
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
> index a287577d1ad6..7a7855555d6d 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -350,9 +350,14 @@ int blkdev_zone_mgmt_ioctl(struct block_device *bdev, blk_mode_t mode,
>   
>   static inline bool disk_zone_is_conv(struct gendisk *disk, sector_t sector)
>   {
> -	if (!disk->conv_zones_bitmap)
> -		return false;
> -	return test_bit(disk_zone_no(disk, sector), disk->conv_zones_bitmap);
> +	bool is_conv;
> +
> +	rcu_read_lock();
> +	is_conv = disk->conv_zones_bitmap &&
> +		test_bit(disk_zone_no(disk, sector), disk->conv_zones_bitmap);
> +	rcu_read_unlock();
> +
> +	return is_conv;
>   }

The above code can be simplified significantly by using guard(rcu).

Otherwise the two patches in this series look good to me.

Thanks,

Bart.