Re: [PATCH v2] block: fix the initial value of wp_offset for npo2 zone size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/6/24 12:16, Bart Van Assche wrote:
> On 11/5/24 4:02 PM, LongPing Wei wrote:
>> The zone size of Zoned UFS may be not power of 2.
>> It should be better to get wp_offset by bdev_offset_from_zone_start
>>   instead of open-coding it.
> 
> Hi LongPing,
> 
> As Christoph already explained, only zone sizes that are a power of 2
> are supported by the Linux kernel. Hence, patches that mention npo2
> zone size support in the patch description probably will be ignored.
> 
> I'm wondering if this patch would become acceptable if the description
> would be changed into something like "Call bdev_offset_from_zone_start()
> instead of open-coding it."

Agreed. That is a much better commit message.

> 
> Thanks,
> 
> Bart.


-- 
Damien Le Moal
Western Digital Research




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux