On Wed, Oct 30, 2024 at 11:19:00AM +0000, John Garry wrote: > + granularity = bdev_discard_granularity(bdev) ?: > + bdev_physical_block_size(bdev); The discard granularity is always set to at least the physical block size, so this can be simplified to: granularity = bdev_discard_granularity(bdev);