On Fri, Oct 18, 2024 at 09:12:20AM -0700, Bart Van Assche wrote: > On 10/17/24 9:09 AM, Keith Busch wrote: > > @@ -156,7 +155,7 @@ struct request { > > struct blk_crypto_keyslot *crypt_keyslot; > > #endif > > - enum rw_hint write_hint; > > + unsigned short write_hint; > > Why 'u16' for ki_write_hint and 'unsigned short' for write_hint? Isn't > that inconsistent? It's consistent with the local convetion of the existing structs. Some use unsiged short, others use u16. It looks weird to mix the types within the same struct.